Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: support change from auto_inc to auto_random through 'alter table' (#20512) #24608

Merged
merged 5 commits into from
May 13, 2021
Merged

ddl: support change from auto_inc to auto_random through 'alter table' (#20512) #24608

merged 5 commits into from
May 13, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented May 13, 2021 •
edited
Loading

cherry-pick #20512 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24608

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24608:release-4.0-67acdf3e9091

What problem does this PR solve?

Issue Number: close #19299.

What is changed and how it works?

What's Changed:

  • Relax the check and allow convert BIGINT auto_increment primary key to an auto_random one.
  • During the change:
    • Clean the auto-id count in meta.
    • Remove the old auto-id allocator.
    • Add a new auto_random id allocator when applyDiff.

How it Works: Omitted.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • ? Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

N/A

Release note

  • Allow changing an AUTO_INCREMENT column to an AUTO_RANDOM one.

@ti-srebot
cherry pick pingcap#20512 to release-4.0
abf964e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request May 13, 2021
Merged
@ti-srebot ti-srebot added sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/4.0-cherry-pick labels May 13, 2021
@ti-srebot ti-srebot added this to the v4.0.13 milestone May 13, 2021
@ti-srebot
Copy link
Contributor Author

@tangenta you're already a collaborator in bot's repo.

@AilinKid
Copy link
Contributor

/cc @tangenta

@ti-chi-bot ti-chi-bot requested a review from tangenta May 13, 2021 02:48
AilinKid
AilinKid reviewed May 13, 2021
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 13, 2021
@crazycs520
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 13, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 13, 2021
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: e877cbd

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 13, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 9b2443a into pingcap:release-4.0 May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 Awaiting requested review from bb7133

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@tangenta tangenta Awaiting requested review from tangenta

Assignees

@tangenta tangenta

Labels
cherry-pick-approved Cherry pick PR approved by release team. sig/sql-infra SIG: SQL Infra size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.13
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @AilinKid @crazycs520 @ti-chi-bot @zhouqiang-cl @tangenta